Skip to content

L132311: Fixing CDATA formatting #3366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

v-maudel
Copy link
Contributor

Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description: the Markdown CDATA content is incorrectly formatted in source files, moreover it is breaking the target publishing builds since the content inside those tags are being processed as XML tag instead of Markdown content.

Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.
Description: the Markdown CDATA content is incorrectly formatted in source files, moreover it is breaking the target publishing builds since the content inside those tags are being processed as XML tag instead of Markdown content.
@v-maudel
Copy link
Contributor Author

v-maudel commented Oct 18, 2019

Hi @rpetrusha , @mairaw , can you please help by merging this PR?

Also, I would like to ask your help to fix this other file at lines 14122+14123, 14189+14190, 14358+14359 . I cant edit it because it's to big and the edit options are not available.
image

@mairaw mairaw added this to the October 2019 milestone Oct 18, 2019
@mairaw mairaw added the loc Indicates issues that are about localized content label Oct 18, 2019
Copy link
Contributor

@mairaw mairaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v-maudel. The formatting we usually use is a bit different. Left suggestions to fix that.

And @rpetrusha has retired from the company last week.

@v-maudel
Copy link
Contributor Author

Thanks @mairaw , I wasn't aware Ron was retired, good for him. :)
The changes I made was according to suggestions from previous fixes, (to only remove spaces before CData tag) but I added your commits.

@v-maudel
Copy link
Contributor Author

Hi @mairaw , if this is good to go can you please merge it or if you add it to a sprint, can you please let me know when it will be fixed?
Also, can you please edit this one https://github.com/dotnet/dotnet-api-docs/blob/master/xml/System/String.xml? It needs the same fix but I can't see it because GIthub says it is too big.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
loc Indicates issues that are about localized content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants